arena icon indicating copy to clipboard operation
arena copied to clipboard

feat(types): add typescript definitions / add named export run

Open ejhayes opened this issue 4 years ago • 3 comments

Changes Made

  • Add typescript declarations to this project (see package.json which includes types reference and script generate:types)
  • Add named export run which exports both app and queue. Simplifies process of adding/removing queues from arena. This does not change default behavior!
  • Updates to README.md

Potential Risks

  • Type definitions will not work if they are missing from the package (new behavior so unlikely to break anything)

Test Plan

  • Ensure existing examples in example/ directory work. I have confirmed these work for me

Checklist

  • [x] I've increased test coverage
  • [x] Since this is a public repository, I've checked I'm not publishing private data in the code, commit comments, or this PR.

ejhayes avatar May 19 '21 18:05 ejhayes

Hi @bradvogel - when you get a chance can you take a look at this PR?

ejhayes avatar May 19 '21 19:05 ejhayes

Can you rebase on the latest origin/master? It looks like this PR diff is picking up some unrelated changes.

bradvogel avatar May 20 '21 17:05 bradvogel

Changes rebased against upstream master. Take a look now @bradvogel

ejhayes avatar May 20 '21 19:05 ejhayes