netman.nvim icon indicating copy to clipboard operation
netman.nvim copied to clipboard

API Rewrite/Libuv Shim

Open miversen33 opened this issue 3 years ago • 1 comments

This will be a dangling PR so I can start linking issues to it.

miversen33 avatar Aug 15 '22 08:08 miversen33

There is alot going on in this PR so its worth calling out each big piece of this. Note: This is an abnormal PR, usually multiple features/changes wont be included in one big merge like this. Consider this a 1 time thing.

This PR addresses several issues:

  • #61
  • #44
  • #28

The biggest of which is #28 which effectively required a rewrite of the core API. This rewrite was not able to be done (reasonably) in small enough chunks to warrant a better PR (sorry about that future Mike, I'm sure you will hate this).

**Additionally, this PR includes a backwards breaking change due to #61 **. This is unlikely to affect anyone as it does not appear that anyone has started integrating with Netman yet. But its still worth calling out. Sorry 😦

There will likely be a bit more work that needs to be done to get libruv (The netman libuv shim) fully functional.

Note: Libruv is a convenience/shim layer and will not get any updates for specific file explorers. Explorers should integrate netman into themselves as a source if they wish to use Netman.

More details will follow.

miversen33 avatar Aug 15 '22 08:08 miversen33

For anyone watching this PR, all that we have left is to flesh out the Unit Tests for the changes to ensure they are "stable". Adding a target date to the Milestone

miversen33 avatar Sep 06 '22 04:09 miversen33

looking forward to see this get merged :D

luxus avatar Oct 16 '22 17:10 luxus

I'm slowing picking through the various Unit Tests I need to have in place to get this in a spot I feel comfortable merging into v1.1. I have a few more tests left on the "SSH" provider, and then I should be a spot where I can run v1.1 in "production" for some real world testing. I have been running this branch in production for a few months but am still encountering some issues which is why there are so many commits on this PR (vs a more traditional PR which is a few commits and encompasses one idea/feature/fix).

Its getting there though :)

miversen33 avatar Oct 16 '22 22:10 miversen33

oh sounds wonderful, then i will maybe try this PR even before the merge

luxus avatar Oct 17 '22 20:10 luxus

This was inadvertanly closed but Im kinda ok with it as v1.1 is in a good enough spot for me to move forward with getting configuration development started (new branch incoming).

miversen33 avatar Oct 17 '22 21:10 miversen33