insta icon indicating copy to clipboard operation
insta copied to clipboard

MSRV Policy

Open mitsuhiko opened this issue 2 years ago • 3 comments

I wanted to originally support old Rust versions for as long as I can since insta is a testing tool and as a user you never want to be in a situation where you cannot test your own crate to your own preferred version ranges because your test tool moves you up.

Unfortunately the world is moving up around insta right now:

  • Insta currently depends on once_cell, which moved up to 1.56: https://github.com/matklad/once_cell/issues/201: potential workaround is to ditch once_cell
  • similar uses bstr which in the 1.x release train moved up to 1.60. This is a bit of a weird situation since this is my own crate but there are users who would like the new version to avoid duplicates: https://github.com/mitsuhiko/similar/pull/40
  • console uses once_cell which indirectly now moved to 1.56: https://github.com/console-rs/console/issues/134
  • toml is moving up to 1.60 but they are open to making this a semver bump: https://github.com/toml-rs/toml/issues/346

A few other things already moved up, some of which we dropped in the process (see #214)

I have not yet decided what I want to do here, but one way is to drop once_cell for now and not to upgrade in similar to postpone this issue for a while. Potentially the discussion in the community settles by then. It seems like the community is abandoning supporting old rustc versions in general (see https://github.com/rust-lang/libs-team/issues/72).

mitsuhiko avatar Sep 25 '22 21:09 mitsuhiko

For now I'm postponing a decision here. I have restored the intended MSRV policy by dropping once_cell in the interim.

mitsuhiko avatar Sep 28 '22 12:09 mitsuhiko

syn bumped its MSRV up to 1.56 with the v2 release. This alone will bump the MSRV of a lot of projects to at least 1.56 once updates propagate out

I don't think we depend on syn with all features off, but any feature requiring serde will pull it in with a non-semver breaking change

CosmicHorrorDev avatar Mar 27 '23 00:03 CosmicHorrorDev