I had compiler errors and warnings when compiling for VS 2019. Would you like me to submit my changes via pull request?

[gt0327e]

[gt0327e]

I tried making a pull request on a new branch according to the instructions in Contributing.rst but was rejected by the server.

[svenevs]

@gt0327e it sounds like you tried to push to our repository, you don't have write access here. You need to create a fork and push your changes there, then open a pull request to this repository.

You can alternatively just post your changes here. git diff > changes.txt and upload changes.txt here, or paste it in a code-block if it's relatively brief:

```diff
paste changes between backticks
```

If you could state what your build problems are that would be helpful, I'm getting very close to opening a PR that should resolve a lot of build problems. Hopefully yours will fit in this category ;)

[gt0327e]

My main build problem was that I had to #include stdexcept in several files because of the VS2019 didn't know what std::runtime_error was without it. That's pretty much it.

changes.txt

[wjakob]

Hi @gt0327e,

I just committed a accompanied version of your change. Could you take a look to see if that fixes the problem? Also, can you send a transcript of the compiler warnings you got? I'd like to target them more specifically at the responsible lines or change the code so that it doesn't generate warnings at all.

Best, Wenzel

[gt0327e]

nanogui-obj.log example1.log

Problem solved. Thanks Wenzel. Complete VS2019 build log with compile warnings attached.

I'm not using example1 but it has an unresolved external symbol. Compile log attached. I'm happy to check if any fix you submit corrects the unresolved external.