mitsuba icon indicating copy to clipboard operation
mitsuba copied to clipboard

Fix gcc 5.4 build

Open mlamarre opened this issue 6 years ago • 2 comments

This PR adds the CXX switch -std=c++11 in config-linux-gcc.py.

I don't know why I'm the first to hit this, but If I don't specify -std=c++11, I get the same build errors as in this issue: https://github.com/mitsuba-renderer/mitsuba/issues/7

I'm building from a minimal Ubuntu 16.04 docker file. I noticed the debug variant already had the c++11 switch at the end, I moved it to the front. There's an extra -fPIC switch in CXXFLAGS in the debug variant. Removed it and it's still added to every g++ calls so it's unnecessary.

mlamarre avatar Feb 21 '18 17:02 mlamarre

Seems reasonable -- can you leave the -fPIC flag? I want to ensure that it really gets used for every target (not just shared libraries).

wjakob avatar Feb 21 '18 19:02 wjakob

I put back fPIC and also add it to the release file.

mlamarre avatar Feb 22 '18 21:02 mlamarre