drjit icon indicating copy to clipboard operation
drjit copied to clipboard

Patch/gcc11

Open tomix1024 opened this issue 3 years ago • 1 comments

When including the intrinsics in include/drjit/packet_intrin.h, GCC expects us to include the immintrin.h header instead of the individual headers. In GCC 11 however, the bmi2intrin.h headers are expected to be included via x86gprintrin.h. This PR adds the missing "workaround" definition if GCC >= 11.

tomix1024 avatar Aug 05 '22 12:08 tomix1024

Thanks for the PR @tomix1024 ! Looking at the build log, it looks like the CI failure is unrelated to your change (rather some driver issue on the CI machine). We'll take a look when we're back from SIGGRAPH.

merlinND avatar Aug 05 '22 12:08 merlinND

Sorry, I completely lost track of this.

This looks good to me.

I checked the headers of GCC 11 and 12, we should be able to get away for all our intrinsic includes with just _IMMINTRIN_H_INCLUDED and _X86GPRINTRIN_H_INCLUDED.

Right now, _X86INTRIN_H_INCLUDED is not needed.

njroussel avatar Oct 14 '22 12:10 njroussel