saf icon indicating copy to clipboard operation
saf copied to clipboard

Move `saf generate xccdf2inspec_stub` to use @mitre/inspec-objects

Open camdenmoors opened this issue 1 year ago • 2 comments

This improves CIS conversion and adds OVAL definition support

camdenmoors avatar Jul 27 '22 14:07 camdenmoors

This pull request has a conflict. Could you fix it @camdenmoors?

mergify[bot] avatar Aug 05 '22 15:08 mergify[bot]

Seems like we have some merge conflicts

aaronlippold avatar Aug 06 '22 00:08 aaronlippold

@camdenmoors @em-c-rod @wdower this connects to delta as well given that we want to ensure that stubs generates the same inspec code style as delta

aaronlippold avatar Dec 12 '22 16:12 aaronlippold

How come we got rid of this code? https://github.com/mitre/saf/pull/564/files#diff-9b4eacf4f12e389fa17ca7978d25358f3fa304f1b4ef7597ec398b0fbed998dcL51-L67

aaronlippold avatar Dec 15 '22 00:12 aaronlippold

How come we got rid of this code? https://github.com/mitre/saf/pull/564/files#diff-9b4eacf4f12e389fa17ca7978d25358f3fa304f1b4ef7597ec398b0fbed998dcL51-L67

There were basically two different implementations of parsing and writing out the InSpec controls - one here and one in ts-inspec-objects. This PR replaces the implementation here with referencing that in ts-inspec-objects instead.

em-c-rod avatar Dec 15 '22 14:12 em-c-rod

This pull request has a conflict. Could you fix it @camdenmoors?

mergify[bot] avatar Jan 03 '23 22:01 mergify[bot]