heimdall2 icon indicating copy to clipboard operation
heimdall2 copied to clipboard

Remove libxmljs2

Open Amndeep7 opened this issue 1 year ago • 5 comments

Manually delete libxmljs2 which is an optional dependency for @cyclonedx/cyclonedx-library. this optional dependency adds architecture specific binaries to the node_modules, which we do not want since they get packaged with hdf-converters. hdf-converters is used in the saf cli where we are trying to make noarch rpm binaries.

Amndeep7 avatar Sep 04 '24 19:09 Amndeep7

This pull request has a conflict. Could you fix it @Amndeep7?

mergify[bot] avatar Sep 04 '24 19:09 mergify[bot]

I'll fix the merge conflict once this is approved and all the other tests pass @wdower. Dependabot got some changes in while I was working this I guess.

Amndeep7 avatar Sep 04 '24 19:09 Amndeep7

nvm there seems to be a netlify issue that requires more thinking @wdower

Amndeep7 avatar Sep 04 '24 20:09 Amndeep7

This pull request has a conflict. Could you fix it @Amndeep7?

mergify[bot] avatar Sep 07 '24 01:09 mergify[bot]