heimdall2 icon indicating copy to clipboard operation
heimdall2 copied to clipboard

Add Threat Column

Open ejaronne opened this issue 1 year ago • 2 comments

DO NOT MERGE AS IS - REMOVES THE RUNTIME COLUMN

Add threat column to control rows (initially just replace Run Time with Related Threats)

Before merging:

  • [ ] Re-add runtime column
  • [ ] Figure out solution for adding/removing desired columns
  • [ ] URLs include user provided values so make sure to sanitize those inputs
  • [ ] Come up with a better algorithm for sorting

W/r to the control summary

  • [ ] Confirm names
  • [ ] Remove console logs
  • [ ] Flesh out documentation
  • [ ] Write saf cli integration
  • [ ] Sonarqube doesn't understand when || is correct behavior as opposed to ?? so go and correct the warnings in the branch and then again on merge

ejaronne avatar Oct 23 '23 15:10 ejaronne

image got sorting working for threats - currently 'no threats' are considered 'less than' threats so ascending sort has nothing at the top and descending sort goes from greatest to least threat by alphanumeric order / standard string comparison

Amndeep7 avatar Oct 30 '23 03:10 Amndeep7

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Nov 08 '23 20:11 sonarqubecloud[bot]