heimdall2 icon indicating copy to clipboard operation
heimdall2 copied to clipboard

Published 20 hours ago • verified publisher icon mitre

Enhance SAF ASFF2HDF and HDF2ASFF converter tools

Open ejaronne opened this issue 2 years ago • 2 comments

  • [ ] Auto extract the findings using asff2hdf via API when converting to HDF for downstream use.
  • [x] Preserve passthrough object information in asff (and reconstitute in asff2hdf)
  • [x] Preserve controls.code objects in asff (and reconstitute in asff2hdf)
  • [ ] Generate asff objects by InSpec control ID (NOT NIST SP-800-53 controls) as opposed to each sub-test done in current version. i.e., keep the results for a specific InSpec control ID together just like in normal HDF and include a calculated Status to coincide with the ASFF compliance Status. i.e., for a RHEL7 STIG with 247 requirements, we should generate only 248 asff json objects (1 header/execution asff json plus 247 control IDs)
  • [ ] Handle case where only an execution finding is present

ejaronne avatar Apr 06 '22 17:04 ejaronne

@camdenmoors the 2nd and 3rd items are checked but I can't find a branch or PR related?

ejaronne avatar Jun 04 '22 01:06 ejaronne

@camdenmoors the 2nd and 3rd items are checked but I can't find a branch or PR related?

This is because they are already merged: https://github.com/mitre/heimdall2/blob/58b2945804b6574bd834521dccc190aa527c2e5c/libs/hdf-converters/src/converters-from-hdf/asff/transformers.ts#L435 https://github.com/mitre/heimdall2/blob/58b2945804b6574bd834521dccc190aa527c2e5c/libs/hdf-converters/src/converters-from-hdf/asff/transformers.ts#L569 https://github.com/mitre/heimdall2/blob/58b2945804b6574bd834521dccc190aa527c2e5c/libs/hdf-converters/src/asff-mapper/case-hdf2asff.ts#L127

camdenmoors avatar Jun 04 '22 15:06 camdenmoors