caldera icon indicating copy to clipboard operation
caldera copied to clipboard

Update Dockerfile to build vue for 5.0.0

Open cln-io opened this issue 1 year ago • 2 comments

Build vue before packaging with docker.

Closes #2889

Description

As the VUE build is now part of the server.py and needs to be run once before startup we have to include this step in the docker file too, as this is ran on docker build.

allows the docker build to succeed and run in offline / airgapped systems

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

2 docker build systems, MacOS 14.2.1 + Ubuntu 23.04

Checklist:

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [X] I have added tests that prove my fix is effective or that my feature works

cln-io avatar Feb 20 '24 11:02 cln-io

@cln-io On our queue.

elegantmoose avatar Feb 22 '24 19:02 elegantmoose

LGTM.

@clenk Can you take a look when you have a minute.

elegantmoose avatar Feb 23 '24 15:02 elegantmoose

Thank you @cln-io

elegantmoose avatar Mar 12 '24 19:03 elegantmoose