mitogen icon indicating copy to clipboard operation
mitogen copied to clipboard

Published 20 hours ago • verified publisher icon mitogen-hq

Fix loading of ssh connection class

Open markafarrell opened this issue 2 years ago • 4 comments

What?

Fix loading ssh connection class. get_with_context returns a tuple (https://github.com/ansible/ansible/blob/952ee88f33de4d49ff5f7bd4bec3431a4b0fdc78/lib/ansible/plugins/loader.py#L895) but we were not treating it as a tuple

Fixes #766 #662 #342

markafarrell avatar Dec 13 '22 05:12 markafarrell

@moreati any way we can get this accepted?

hishamanver avatar Feb 06 '23 14:02 hishamanver

LGTM

hishamanver avatar Aug 02 '23 07:08 hishamanver

Notes to self

  • ansible.plugins.loader.PluginLoader.get_with_context() was added in https://github.com/ansible/ansible/commit/984216f52e76b904e5b0fa0fb956ab4f1e0a7751, first tagged in v2.10.0b1. It returns a namedtuple containing the loader object
  • ansible.plugins.loader.PluginLoader.get() call this method, then returns the loader object.

moreati avatar Aug 07 '23 15:08 moreati

@moreati For reference see https://github.com/markafarrell/mitogen-issue-766-repro for instructions for reproducing the issue

markafarrell avatar Aug 07 '23 23:08 markafarrell