mitogen icon indicating copy to clipboard operation
mitogen copied to clipboard

Ansible-core 2.14 support

Open vanyasvl opened this issue 2 years ago • 24 comments

Ansible-core 2.14.0 was released yesterday.

Please add support to mitogen.

Thanks.

vanyasvl avatar Nov 08 '22 10:11 vanyasvl

you're aware that #966 is still open so afaik mitogen doesn't support (yet) ansible-core 2.13 ... haven't checked in a while but still the reason why I stick with ansible-core 2.12 for the moment

arrfab avatar Nov 10 '22 08:11 arrfab

you're aware that #966 is still open so afaik mitogen doesn't support (yet) ansible-core 2.13 ... haven't checked in a while but still the reason why I stick with ansible-core 2.12 for the moment

Yep, so Mitogen project looks rather dead than alive

vanyasvl avatar Nov 10 '22 08:11 vanyasvl

Yep, so Mitogen project looks rather dead than alive

It seems so. I filed #945 four months ago and we had to stop using it because of that. Nobody has even commented to try to help.

It's a shame because it was a great project and made Ansible so fast. But that's how it goes with open source. I'd love to contribute since I do know Python but I don't know enough to help in a project like this.

apple4ever avatar Nov 10 '22 12:11 apple4ever

Yep, so Mitogen project looks rather dead than alive

It seems so. I filed #945 four months ago and we had to stop using it because of that. Nobody has even commented to try to help.

It's a shame because it was a great project and made Ansible so fast. But that's how it goes with open source. I'd love to contribute since I do know Python but I don't know enough to help in a project like this.

Actually the "fast" part should be inside ansible core. Why ansible core does not implement it is hard to understand.

ghost avatar Dec 13 '22 10:12 ghost

FWIW - just bumping ANSIBLE_VERSION_MAX to (2, 14) allows my plays to run. YMMV.

opoplawski avatar Dec 13 '22 16:12 opoplawski

TASK [community.zabbix.zabbix_agent : Do a yum clean] ****************************************************************************************************************************************
fatal: [*mx.*.*]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (ansible.legacy.command) module: warn. Supported parameters include: executable, argv, removes, chdir, _uses_shell, stdin_add_newline, stdin, strip_empty_ends, creates, _raw_params."}

it's broken with forced 2.14 support

badfiles avatar Dec 13 '22 16:12 badfiles

it's broken with forced 2.14 support

I have it without mitogen, removing warn helps, so it is not a mitogen problem.

nerijus avatar Dec 13 '22 18:12 nerijus

FWIW - just bumping ANSIBLE_VERSION_MAX to (2, 14) allows my plays to run. YMMV.

I try it but gather fact failed with this.. So force use Ansible-core 2.12... (Ansible 5)

NikitaCOEUR avatar Feb 03 '23 17:02 NikitaCOEUR

FWIW - just bumping ANSIBLE_VERSION_MAX to (2, 14) allows my plays to run. YMMV.

Just curious .. myself I'd need to bump to 2.14 but mitogen is still the only thing that doesn't work with it .. can you elaborate on the ANSIBLE_VERSION_MAX ? you mean directly in mitogen and so bypass all checks ?

arrfab avatar Feb 11 '23 10:02 arrfab

FWIW - just bumping ANSIBLE_VERSION_MAX to (2, 14) allows my plays to run. YMMV.

Just curious .. myself I'd need to bump to 2.14 but mitogen is still the only thing that doesn't work with it .. can you elaborate on the ANSIBLE_VERSION_MAX ? you mean directly in mitogen and so bypass all checks ?

Yes.

opoplawski avatar Feb 11 '23 16:02 opoplawski

I ack that, I've run a rather big codebase on ansible-2.14 and mitogen with patched version restriction and it just worked.

May be we can allow users to override this restriction via environment variable or some other mechanism. End-user patching is madness.

amarao avatar Feb 11 '23 18:02 amarao

Yes, or better : have a new mitogen tag/release that would have that ? Wondering if a mitogen dev can consider this, assuming that there were enough feedback about it working with ansible-core 2.14 (or list what would still be problematic, etc)

@moreati : opinion on this ?

arrfab avatar Feb 11 '23 18:02 arrfab

how about introducing some configuration parameter here https://github.com/mitogen-hq/mitogen/blob/8cda5f55375e3c5caa77d900d1bfa90c5fea0094/ansible_mitogen/loaders.py#L54 for skipping that check / allowing to use Ansible Mitogen with Ansible not officially/tested/supported version? of course at own risk...

from my perspective using Mitogen is very valuable and it just decreases Ansible execution time by minutes for free it is just very sad that right now there is no Mitogen version officially compatible with any maintained Ansible version.

The most recent version of Ansible that works with Mitogen I found is 5.10.0:

image

I have no Python skills and I am unable to help but if there is sb that could help with making Mitogen up-to-date with some recent version of Ansible ... then I will not hesitate and buy such a person a beer ;)

krystian-panek-vmltech avatar Mar 13 '23 08:03 krystian-panek-vmltech

Waiting for 2.14 support here too, any update?

HOSTED-POWER avatar May 10 '23 07:05 HOSTED-POWER

PS: I forked current repo and changed ANSIBLE_VERSION_MAX = (2, 14) in the loaders.py

Added it inside our execution environment and it seems to run fine so far

HOSTED-POWER avatar May 10 '23 08:05 HOSTED-POWER

Any possibility to bump he version max?

djuarezg avatar Jul 05 '23 09:07 djuarezg

https://galaxy.ansible.com/serverscom/mitogen

It will patch it for you and upatch back automatically.

amarao avatar Jul 06 '23 09:07 amarao

PS: I forked current repo and changed ANSIBLE_VERSION_MAX = (2, 14) in the loaders.py

Added it inside our execution environment and it seems to run fine so far

It seems that delegate_to tasks are broken. Or does it work for anybody?

ksyblast avatar Jul 07 '23 11:07 ksyblast

Due to ongoing, long-standing problems with catching up with newer ansible versions, my employer decided to abandon mitogen. We'll miss the speed but the constant tinkering so that it might work "well enough" without spitting traces onto stdout and seemingly work only for the next Ansible minor to make incompatible again made us give up on it completely. ☹️

And to be perfectly honest, the frequency of things being merged to master (let me know if you use mainly use a different branch?) is not inspiring confidence. Screenshot 2023-07-07 at 13 43 48

GhostLyrics avatar Jul 07 '23 11:07 GhostLyrics

maintaining VMs these days is a niche ... so maintaining advanced tools for maintaining VMs is even super niche ;) that's why I guess Mitogen has no sufficient support and only volunteers could push it forward.

@GhostLyrics almost the same on my side. to use AWS SSM / public IP less approach to connect to Ansible I needed more recent version of Ansible and that caused that I am no longer able to use Mitogen...

krystian-panek-vmltech avatar Jul 31 '23 06:07 krystian-panek-vmltech

seems ansible-core 2.13 is now EoL, based on ansible-core-support-matrix

quickchase avatar Nov 08 '23 17:11 quickchase

PS: I forked current repo and changed ANSIBLE_VERSION_MAX = (2, 14) in the loaders.py Added it inside our execution environment and it seems to run fine so far

It seems that delegate_to tasks are broken. Or does it work for anybody?

Same in here... We cannot upgrade Ansible because if we do we need to remove Mitogen... And given previous versions are already on EOL this should be given a bit of attention.

djuarezg avatar Nov 22 '23 10:11 djuarezg

Hate to beat a dead horse, but I, too, would be very interested to see compatibility with Ansible 2.14. We are maintaining an Open Source software with lots of configuration files on VM clusters for our clients and the speedup with Mitogen used to be considerable. Very sad we can't use it anymore. .__.

KatrinIhler avatar Dec 06 '23 12:12 KatrinIhler

PS: I forked current repo and changed ANSIBLE_VERSION_MAX = (2, 14) in the loaders.py Added it inside our execution environment and it seems to run fine so far

It seems that delegate_to tasks are broken. Or does it work for anybody?

Same in here... We cannot upgrade Ansible because if we do we need to remove Mitogen... And given previous versions are already on EOL this should be given a bit of attention.

Is the delegate_to related to any of the other delegate_to issues reported to mitogen? A basic delegate_to task works for me with ansible 2.15.3 and a patched version of mitogen to allow that version.

opoplawski avatar Dec 06 '23 16:12 opoplawski

PR https://github.com/mitogen-hq/mitogen/pull/1017 adds Ansible 7 (core 2.14) support. Please try it and reply with any good or bad results. If all is well this will go into master, and then release 0.3.6. Sorry for the long wait.

moreati avatar Mar 29 '24 10:03 moreati

PR #1017 adds Ansible 7 (core 2.14) support. Please try it and reply with any good or bad results. If all is well this will go into master, and then release 0.3.6. Sorry for the long wait.

Good to know there is a PR for 2.14, pls consider 2.15 as well https://github.com/mitogen-hq/mitogen/issues/1021

YanFenGuo avatar Mar 29 '24 10:03 YanFenGuo

Mitogen 0.3.6 is now out.

moreati avatar Apr 04 '24 13:04 moreati