Fix templated ansible_ssh_common_args issues

Open momiji opened this issue 3 years ago • 6 comments

Fixes #905

Aug 22 '22 11:08 momiji

@momiji you may want to add fixes #905 to the description so GitHub successfully links the PR to the issue as its patch/fix.

Aug 23 '22 09:08 Zocker1999NET

@Zocker1999NET Sure, but where? In the title, or in the text below? Sorry, I've never done this before...

Aug 23 '22 09:08 momiji

@Zocker1999NET Sure, but where? In the title, or in the text below? Sorry, I've never done this before...

@momiji just add it to description, I don't think GitHub parses the title for that. And try to not put in a header like you already did, as GH didn't recognize that either. Probably good2know, you can use different keywords as well, see here

Aug 23 '22 18:08 Zocker1999NET

@moreati Are there any plans to merge this? It looks like it would fix some long-standing issues (e.g. #599).

Jul 11 '24 17:07 setpill

~~Nevermind, applying this diff to 0.3.7 does not fix the issue for me.~~

Correction: this does fix the ssh_common_args, but I am running also into the issue that a templated ssh_user is not correctly handled.

Jul 12 '24 09:07 setpill