mitogen-hq
Handle module.__file__ == None
It's been discovered that some modules have the __file__ property being set as None. An example of a such module is backports.
Providing None to os.path.abspath() causes an exception: TypeError: expected str, bytes or os.PathLike object, not NoneType
Related to
- https://github.com/mitogen-hq/mitogen/issues/946
Has been used in the Nix environment:
- Python 3.11.8
- Ansible 2.13.13
- Mitogen 0.3.4 (with this patch)
Looking at the errors at one of the failing workflows (https://dev.azure.com/mitogen-hq/mitogen/_build/results?buildId=671&view=logs&j=38fb768a-91bc-52fb-9300-923df8625209&t=0744b325-ce4a-569b-7cdc-1da0e44989ad&l=25)
ERROR: FAIL could not package project - v = InvocationError('/Library/Frameworks/Python.framework/Versions/3.12/bin/python setup.py sdist --formats=zip --dist-dir /Users/runner/work/1/s/.tox/dist', 1)
Not sure it's related to the change.
Also https://dev.azure.com/mitogen-hq/mitogen/_build/results?buildId=671&view=logs&j=93c724b5-725e-5662-44a0-1d07d9df84a7&t=e0f2306a-4d86-5692-a85d-93c8590e39ad
======================================================================
ERROR: setUpClass (su_test.SuTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/vsts/work/1/s/tests/testlib.py", line 625, in setUpClass
cls.dockerized_ssh = DockerizedSshDaemon(**daemon_args)
File "/home/vsts/work/1/s/tests/testlib.py", line 553, in __init__
self.start_container()
File "/home/vsts/work/1/s/tests/testlib.py", line 533, in start_container
self._get_container_port()
File "/home/vsts/work/1/s/tests/testlib.py", line 510, in _get_container_port
self.port = int(bport)
ValueError: invalid literal for int() with base 10: ':]:32768'
By the way, the base branch for it is stable, please let me know if it should go to master. I can rebase.
By the way, the base branch for it is
stable, please let me know if it should go to master. I can rebase.
It should be master. I've updated the PR, please rebase.
@moreati rebased onto master.
Some CI jobs are still failing, but I don't have enough knowledge to say if it's expected or not. Please let me know if I should try reproducing it locally.
I've just asked Azure Pipelines to rerun the failed jobs. It's probably a case of flaky tests, they're taking 1 or 2 reruns to get 100% green. Thought I had a ticket for it ...
In general one can trigger rerun of all Azure Pipelines jobs in a github project by adding a comment with "/AzurePipelines r-u-n", without the dashes. https://learn.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#comment-triggers
The __file__ attribute exists there, but it's None
Similar to something like
class X:
def __init__(self):
self.attr = None
x = X()
a = getattr(x, 'attr', 'default value')
print(a)
# prints None
Then, if not handled, the following happens
modpath = os.path.abspath(None)
and causes the error
>>> import os
>>> os.path.abspath(None)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "<frozen posixpath>", line 399, in abspath
TypeError: expected str, bytes or os.PathLike object, not NoneType
Added https://github.com/mitogen-hq/mitogen/wiki/import-and-importlib-notes and mentioned this.
Hunting for other cases that might need fixing
mitogen.master.DefectivePython3xMainMethod.find()looks okaymitogen.master.DefectivePython3xMainMethod.find()looks okaymitogen.corelooks okaymitogen.compat.pkgutilis close to retirement/removal