mitogen icon indicating copy to clipboard operation
mitogen copied to clipboard

Fix --ask-become-pass

Open moreati opened this issue 2 years ago • 1 comments

Previously f1503874de82353cbed8b51408d20fdfa899f8f7 fixed the priority of ansible_become_pass over ansible_become_password, but broke --ask-become-pass. Fixes #952.

moreati avatar Jul 07 '23 20:07 moreati

WIP, one of the tests has regressed

TASK [reset the connection _raw_params=reset_connection] ***************************************************************
Friday 07 July 2023  21:01:05 +0100 (0:00:00.196)       0:05:39.075 *********** 
ERROR! Unexpected Exception, this is probably a bug: AttributeError: 'NoneType' object has no attribute 'get_option'
to see the full traceback, use -vvv
Exception occurred while running: ['./run_ansible_playbook.py', 'all.yml', '-i', '/tmp/mitogen_ci_lib9ygmmca5/hosts']
Traceback (most recent call last):
  File "/home/alex/src/mitogen/.ci/ansible_tests.py", line 89, in <module>
    ci_lib.run('./run_ansible_playbook.py %s -i "%s" %s',
  File "/home/alex/src/mitogen/.ci/ci_lib.py", line 86, in run
    ret = subprocess.check_call(argv, **kwargs)
  File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['./run_ansible_playbook.py', 'all.yml', '-i', '/tmp/mitogen_ci_lib9ygmmca5/hosts']' returned non-zero exit status 250.

moreati avatar Jul 07 '23 20:07 moreati

@moreati: Thanks for the more frequent releases. This is one of the patches that Debian has been carrying for a while, and I'd appreciate it if you would re-review it for completion.

stefanor avatar Apr 11 '24 13:04 stefanor

Hi @moreati! Any chance there will be a new mitogen release soon that includes this fix? I'm stuck to mitogen 0.3.3 (and so ansible 5 and python 3.11) because of #726 that seems to be resolved with this fix according to other people. I see the last release was mitogen 0.3.7 on Apr 9, before this fix was merged into master. Thanks for any update on the next release :)

emillumine avatar Jul 22 '24 14:07 emillumine