micromasters icon indicating copy to clipboard operation
micromasters copied to clipboard

Incomplete profiles cause search page to fail

Open noisecapella opened this issue 8 years ago • 2 comments

Since the profiles are not validated on the server side we need to be careful of tolerating missing fields in the client side, otherwise a user may break search by PATCHing their own profile to eliminate a field.

We won't index any profiles that are not complete (i.e. profiles that don't have the filled_out boolean set to true)

noisecapella avatar Aug 04 '16 16:08 noisecapella

In what way does search fail? I would expect ES to be fine with missing fields

pdpinch avatar Aug 04 '16 16:08 pdpinch

It's not search which fails, just the search page. I ran into a couple errors regarding the profile country being null and another profile being missing (why it was missing in the first place I'm not sure)

noisecapella avatar Aug 04 '16 16:08 noisecapella