micromasters icon indicating copy to clipboard operation
micromasters copied to clipboard

Published 20 hours ago • verified publisher icon mitodl

Configuration variables cleanup

Open shaidar opened this issue 1 year ago • 7 comments

We are working on managing Micromasters Heroku configuration variables through Saltstack similar to how we manage those for the other apps. When looking through the different envs (CI, RC, and Production) and searching through settings.py, the keys below came into question. It would be great if someone can confirm whether those keys can be removed:

  • [x] ELASTICSEARCH_DEFAULT_PAGE_SIZE
  • [x] ELASTICSEARCH_HTTP_AUTH
  • [x] ELASTICSEARCH_INDEX
  • [x] ELASTICSEARCH_SHARD_COUNT
  • [x] ELASTICSEARCH_URL
  • [x] EXAMS_AUDIT_AWS_ACCESS_KEY_ID
  • [x] EXAMS_AUDIT_AWS_SECRET_ACCESS_KEY
  • [x] EXAMS_AUDIT_ENABLED
  • [x] EXAMS_AUDIT_ENCRYPTION_FINGERPRINT
  • [x] EXAMS_AUDIT_ENCRYPTION_PUBLIC_KEY
  • [x] EXAMS_SSO_CLIENT_CODE
  • [x] EXAMS_SSO_PASSPHRASE
  • [x] EXAMS_SSO_URL
  • [x] FEATURE_ENABLE_EDX_EXAMS
  • [ ] FEATURE_ENABLE_PROGRAM_LETTER
  • [ ] FEATURE_MITXONLINE_LOGIN
  • [x] FEATURE_PEARSON_EXAMS_SYNC
  • [x] FEATURE_TURN_PAYMENT_OFF
  • [x] FEATURE_USE_COMBINED_FINAL_GRADE
  • [ ] MICROMASTERS_ECOMMERCE_EMAIL

shaidar avatar Mar 02 '23 14:03 shaidar

Anna verified that the checked off FEATURES above are no longer needed.

shaidar avatar Mar 02 '23 14:03 shaidar

My initial thought:

I think all the config keys related to Elastic Search might not have been used now since we have migrated from Elastic Search to Open Search recently.

Specifically looked briefly at the settings file changes there, we have removed these from the settings in the code and I don't see their usage in the code anymore which makes sense.

arslanashraf7 avatar Mar 02 '23 15:03 arslanashraf7

@rhysyngsun can you take a look at this? I think all _EXAMS_ settings are moot now that we're not working with Pearson any more.

pdpinch avatar Mar 06 '23 14:03 pdpinch

The EXAMS settings don't appear to provide any functionality right now based on a quick code read, but there are still some lingering definitions of them in the code. Just to be sure nothing breaks, those should probably be removed although I don't think anything would break.

rhysyngsun avatar Mar 06 '23 18:03 rhysyngsun

Still used

  • FEATURE_MITXONLINE_LOGIN
  • FEATURE_ENABLE_PROGRAM_LETTER
  • MICROMASTERS_ECOMMERCE_EMAIL

Can be removed

  • FEATURE_PEARSON_EXAMS_SYNC

rhysyngsun avatar Mar 06 '23 18:03 rhysyngsun

I wrote an issue for removing the lingering code for the EXAMS settings, https://github.com/mitodl/micromasters/issues/5314

pdpinch avatar Mar 06 '23 18:03 pdpinch

@annagav Does the latest PR of yours mean we can remove all the EXAMS_* settings from the Heroku configuration variables listed above?

shaidar avatar Mar 15 '23 15:03 shaidar