mito icon indicating copy to clipboard operation
mito copied to clipboard

Investigate unifying JLab 2.0 and JLab 3.0 in a single package

Open naterush opened this issue 2 years ago • 2 comments

Currently, to support both JLab 2.0 and JLab 3.0, we deploy multiple packages. It would be preferable if we could just deploy a single package, and have it all work.

To do this, we might be able to build directly into the mitosheet/labextension folder, and just provide both a ZIP file, and also the rest of the files for the prebuilt extension. This would be very sweet.

This might increase the size of the mitosheet package, which we should investigate...

naterush avatar Feb 07 '22 16:02 naterush

Ok, so we can certainly include both of the files in the labextension folder. The main question is: if we just copy the .tgz into the labextension folder, how do we make it so jlab 2 actually discovers the lab extension?

I think it might have to do with the keywords in the setup.py, which gets put in the metadata. Can we put all of these words? If so, what happens?

naterush avatar Feb 25 '22 02:02 naterush

If we do this successfully, we can get rid of the mitosheet2 package. We would just be left maintaining the mitosheet and mitosheet3 packages (and the latter only because most of our active users are on this one).

More than that, though, this might be able to simplify a lot of our build process. We will see. I def want to figure out if this is possible.

naterush avatar Feb 25 '22 16:02 naterush