mito icon indicating copy to clipboard operation
mito copied to clipboard

"Sign up to Mito" Splash screen appearing after updating Mito

Open twelsh37 opened this issue 2 years ago • 6 comments

Describe the bug Having upgraded to the latest version of mito I am receiving the "sign up to mito" splash screen

To Reproduce Steps to reproduce the behaviour: ackage Version Latest Type


mitoinstaller 0.0.117 0.0.119 sdist mitosheet 0.1.388 0.1.390 wheel 1.From Mitoinstaller v 0.0.117 and mitosheet v 0.1.388 upgrade

python -m pip install mitoinstaller
python -m mitoinstaller install
  1. On running mitosheet after the install I get the splash screen

Expected behavior I would expect mito installer to note previous versions and not pop up the splash screen

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Mito Version mito 0.1.388 -> 0.1.390

twelsh37 avatar Mar 07 '22 20:03 twelsh37

@twelsh37 thanks for the bug report! This is certainly not intended behavior - and we want to get this fixed ASAP.

To help us narrow down the issue, can you try running these same commands again and let me know if it asks you to upgrade again?

I'll get this fixed up ASAP once we get this narrowed down. Thanks again!

naterush avatar Mar 07 '22 21:03 naterush

If it does ask you to upgrade once again, then what must be happening is that your user.json file is getting overwritten with each upgrade. I'm not sure how this would be happening, given the current logic (which explicitly appears to not overwrite the user.json file in either an install or upgrade)...

naterush avatar Mar 07 '22 21:03 naterush

Hey @naterush, This is the first time in a long time I have seen this happen. I try and keep up to date with the releases. I just did the installation again in my environment but this time I did not get the new user dialogue. I will keep an eye out if it happens on the next upgrade.

What is the location of the user.json file? I will check the timestamp and modification date

twelsh37 avatar Mar 07 '22 22:03 twelsh37

Note - I just got this bug as well! Super weird. It's some non-deterministic error that is occurring... because when I promptly ran the command again, it didn't occur. I do not know why this would be.

naterush avatar Mar 14 '22 21:03 naterush

Just upgraded to the latest version and I did not get the error when I missed off --upgrade

From !pip list

mitoinstaller       0.0.123
mitosheet           0.1.393

install was as follows

python -m pip install mitoinstaller
python -m mitoinstaller install

twelsh37 avatar Mar 15 '22 22:03 twelsh37

Good to know! We deployed a fix that should make this bug less likely (although I'm confused how it is even happening in the first place).

I'm gonna rename this issue and keep it around, so we have a place to collect data on it. Please do let me know if you run into this again!

naterush avatar Mar 21 '22 22:03 naterush

Closing as we're removing this signup flow in the future!

naterush avatar Nov 06 '23 18:11 naterush