pdoc icon indicating copy to clipboard operation
pdoc copied to clipboard

Fix link to object if it is exposed in `__all__`

Open nathanthorpe opened this issue 1 year ago • 3 comments

Related issue https://github.com/mitmproxy/pdoc/issues/669

Search through the possible sources of the module when looking in all_modules. Also use the path of the matched object.

nathanthorpe avatar Feb 21 '24 23:02 nathanthorpe

Thanks for looking into it! Ok I believe I've made the appropriate test case. Also added a changelog entry.

nathanthorpe avatar Feb 23 '24 21:02 nathanthorpe

Hi! I'm facing the same issue. Unfortunately, this PR seems a bit stale. Do you plan to continue with this? Do you need a hand?

liborvaneksw avatar Jun 08 '24 18:06 liborvaneksw

This PR should be ready for merge

nathanthorpe avatar Jun 11 '24 19:06 nathanthorpe

Sorry this took so long! I've finally found some time do do a deep dive here and refactor things a bit. Does this look good to you now?

mhils avatar Jul 10 '24 17:07 mhils

I just tested it and it looks great, thank you!

nathanthorpe avatar Jul 10 '24 17:07 nathanthorpe