computational-thinking icon indicating copy to clipboard operation
computational-thinking copied to clipboard

Published 20 hours ago • verified publisher icon mitmath

hw1 quantize check

Open zmoon opened this issue 5 years ago • 1 comments

I feel like the check might be inadequate?

https://github.com/mitmath/18S191/blob/123040947d5b03a572b58c261b3009c8041b5c4e/homework/homework1/hw1.jl#L986-L1000

Since it is checking 0.3, floor with any digits ≥ 1 will pass, when really we want digits=1.

zmoon avatar Sep 15 '20 12:09 zmoon

Yep! Feel free to open a PR

fonsp avatar Sep 20 '20 14:09 fonsp