actions-includes icon indicating copy to clipboard operation
actions-includes copied to clipboard

Make mithro/actions-includes@main work with private workflows

Open piotrlis opened this issue 4 years ago • 3 comments

Executing a check at the beginning of generated workflow doesn't work with private workflows.

Would it be possible to either support private repositories or add possibility to turn off this step?

piotrlis avatar Mar 17 '21 10:03 piotrlis

Two thoughts;

  • Would be happy for someone to add an option to turn off the "up to date" check.
  • I think you could potentially use the GITHUB_TOKEN to get access to the resources?

mithro avatar Mar 17 '21 15:03 mithro

Thanks for quick answer.

I think setting up GITHUB_TOKEN doesn't help in this case, the script that compares generated workflow with the template uses https://raw.githubusercontent.com and doesn't pass the token: https://github.com/mithro/actions-includes/blob/main/actions_includes/check.py#L37

GitHub
Allows including an action inside another action (by preprocessing the Yaml file). This is how composite actions should have worked. - mithro/actions-includes

piotrlis avatar Mar 17 '21 16:03 piotrlis

@piotrlis - We could make it pass the token if it is found.

mithro avatar Mar 17 '21 16:03 mithro