hookpress icon indicating copy to clipboard operation
hookpress copied to clipboard

Replace `split` and `ereg`

Open neiltron opened this issue 8 years ago • 7 comments

This replaces instances of split with explode and instances of ereg with preg_match. Both split and explode were deprecated in PHP 5.3.0 and completely removed in PHP 7.0.0. There is another active pull request that does something similar but only replaces one instance of ereg.

neiltron avatar Feb 24 '17 16:02 neiltron

As we don't have any news from @mitcho , I think we should go for a fork including your PR, and name the plugin hookpress2 to submit it to the Wordpress plugins directory. What do you think about it?

michaelperrin avatar Mar 15 '17 13:03 michaelperrin

@michaelperrin You're welcome to take my pull request and start a fork. I'd prefer to not do that as I think it will get confusing for users. Seems like the best option would be for @mitcho to add someone to the repo and to the plugin on the plugin directory. That way he could have some help reviewing changes in the future. I think he may have taken a step back from open source development, which is totally understandable.

neiltron avatar Mar 16 '17 16:03 neiltron

Hi -- I would strongly advise against this. I know I haven't been attentive but I'll find a new maintainer to take over.

2017/03/15 14:55、Michaël Perrin [email protected] のメッセージ:

As we don't have any news from @mitcho , I think we should go for a fork including your PR, and name the plugin hookpress2 to submit it to the Wordpress plugins directory. What do you think about it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mitcho avatar Mar 16 '17 17:03 mitcho

That's cool then! I thought you weren't around @mitcho and that we wouldn't here from you at all. Keep us posted about this!

michaelperrin avatar Mar 16 '17 17:03 michaelperrin

I'm super interested in this project getting maintained again. Such a brilliant idea. Heck, you could probably charge like $49 for it and people would buy it. I just want to be able to trigger Zapier when a new member joins my WP site. :)

Chaddeus avatar Mar 24 '17 15:03 Chaddeus

https://github.com/corysimmons/hookpress/archive/1.0.0.zip if anyone wants to composer install from this.

"repositories": [
  {
    "type": "package",
    "package": {
      "name": "corysimmons/hookpress",
      "type": "wordpress-plugin",
      "version": "1.0.0",
      "dist": {
        "type": "zip",
        "url": "https://github.com/corysimmons/hookpress/archive/1.0.0.zip"
      }
    }
  }
]

$ composer require corysimmons/hookpress

corysimmons avatar Aug 12 '17 14:08 corysimmons

@mitcho bump 👀

neiltron avatar Oct 16 '17 14:10 neiltron