Ext.ux.touch.grid icon indicating copy to clipboard operation
Ext.ux.touch.grid copied to clipboard

Can't un-set the line-height

Open jacobweber opened this issue 11 years ago • 4 comments

List._buildTpl now sets the line-height style to the list's itemHeight config. But if you set this config to null, to indicate that you don't want the line-height specified, you end up with the CSS "line-height: undefinedpx". It should check to make sure this config isn't null before adding the style.

jacobweber avatar Mar 13 '13 19:03 jacobweber

Ext.ux.touch.grid does not specify itemHeight or the line-height CSS at all.

mitchellsimoens avatar Mar 13 '13 20:03 mitchellsimoens

It does as of this commit:

https://github.com/mitchellsimoens/Ext.ux.touch.grid/commit/22ee937e4d063073e3b2801cf9a3060d67f12813

The default Ext.dataview.List in Sencha Touch 2.1 sets a default value for itemHeight.

jacobweber avatar Mar 13 '13 20:03 jacobweber

You're right, was on a stale branch I had locally.

mitchellsimoens avatar Mar 13 '13 20:03 mitchellsimoens

Can anyone tell me how to create a button in this grid's column....right now i have used xtype:button ...my button is visible but with no text..amy help would be appreciated...thanks in advance

Aswini1226 avatar Mar 19 '13 05:03 Aswini1226