icons icon indicating copy to clipboard operation
icons copied to clipboard

Bummed out by breaking changes

Open friendly opened this issue 3 years ago • 2 comments

Just upgraded to R 4.1.2, and discovered that I can no longer use the `icon` package in my Rmd files. Nor can I install it because somehow `remotes::install_github("ropenscilabs/icon")` vectors to your new `icons` package, and I can't find the `icon` source package to install it for R 4+.

This is a disaster for me because the syntax for icons is so different, e.g., icon::fa("rocket", color="red") vs. icons::icon_style(fontawesome("rocket"), fill="red")

This is probably the worst example of breaking changes I have ever seen. It means I will either have to revert to R 3.6 or else modify all the Rmd files for my web sites that use r icon::fa()

You could have provided some cover functions to make the transition easier.

friendly avatar Jan 10 '22 19:01 friendly

You can install the 'icon' package v0.1.0 with remotes::install_github("mitchelloharawild/[email protected]"). This should allow your old work to continue to run.

Some substantial breaking changes weren't avoidable (such as changing the package name), and so with the migration from ropenscilabs and a complete rewrite of the package to use SVG instead of fonts, I made some design changes to improve the extensibility design of the package.

mitchelloharawild avatar Jan 10 '22 22:01 mitchelloharawild

Design changes to improve extensibility should be made with some consideration of backward compatibility.

Also, you should publicize the availability of the old version.

friendly avatar Jan 11 '22 14:01 friendly

Apologies again for the breaking changes, I've added these install instructions to the README section noting the breaking changes.

mitchelloharawild avatar Aug 10 '23 00:08 mitchelloharawild