nginx-ultimate-bad-bot-blocker
nginx-ultimate-bad-bot-blocker copied to clipboard
[V4] Update to regex on referrers
Regex on referrers needs to be updated to latest format.
But, how is (?:\b)
, a non-capturing group on an empty word boundary, the latest format of \b
? Doesn’t it do the same? As far as performance is concerned, (?:\b)
would be (very) slightly more expensive than \b
as there’ll be more parsing and grouping going on.
Is it for readability enhancement? For users not to make a mistake when they add their customized ones?
But, how is
(?:\b)
, a non-capturing group on an empty word boundary, the latest format of\b
? Doesn’t it do the same? As far as performance is concerned,(?:\b)
would be (very) slightly more expensive than\b
as there’ll be more parsing and grouping going on.Is it for readability enhancement? For users not to make a mistake when they add their customized ones?
I'll change the test unit today to revert back to the original regex and see if any false positives trigger. My brain in rusty lately so struggling recalling why I changed it. I think it might be for better readability let's see what the tests throw out
@issuefiler test unit changed and all test seem to pass OK. Wasted a whole day getting the repo migrated to travis-ci.com which eventually started working after several hours. I will have to test again tomorrow to make sure and ultimately need to start moving the whole process to Github actions as Travis is not what it used to be.