protoc-gen-go-json icon indicating copy to clipboard operation
protoc-gen-go-json copied to clipboard

Proto3 optional field

Open kevpie opened this issue 2 years ago • 3 comments

Enables Marshalling and Unmarshalling the more recent proto3 optional fields capability.

Not thoroughly tested, I hope to use this on some non trivial messages before a merge is even considered.

Looking for feedback and suggestions.

Addresses #13

kevpie avatar Apr 08 '22 21:04 kevpie

Are we planning to merge this pull request?

devesh25427 avatar May 12 '22 07:05 devesh25427

Would be great if we could merge this pull request

awltr avatar Jul 09 '22 19:07 awltr

This seems sufficient to me. The protojson package is doing the heavy lifting supporting optional, this really just needs to declare support

derekperkins avatar Sep 29 '22 04:09 derekperkins

@mitchellh any hesitations about merging this?

derekperkins avatar Feb 01 '23 05:02 derekperkins

This looks good thanks! Apologies for the delay. :)

mitchellh avatar Feb 09 '23 01:02 mitchellh

@mitchellh Please create a new tag

charnan avatar Jun 08 '23 08:06 charnan

Just ran into this problem while trying to use the Buf remote plugin. Unfortunately, Buf only releases updates for stable releases. Any chance this will be released soon?

jalaziz avatar Sep 07 '23 10:09 jalaziz