go-server-timing
go-server-timing copied to clipboard
mitchellh
Go (golang) library for creating and consuming HTTP Server-Timing headers
This change allows for incrementing the metric duration. Good use case for aggregating compute duration for specific methods in a recursive environment. Which is what I use it for. ```...
Fixes #24. This could also be made into an option if people prefer.
Currently durations are rendered as: ``` strconv.FormatFloat(float64(m.Duration)/float64(time.Millisecond), 'f', -1, 64) ``` I think this is over precise: all digits beyond millisecond? That could even be a security issue as somebody...
It seems Firefox supports them now (at least over HTTP2) and Chrome had support for them, but they have currently a regression: https://bugs.chromium.org/p/chromium/issues/detail?id=1280260 Maybe it is time to add support...
Because the handler is currently entirely inside the middleware, it is very difficult to fine tune it (such as enabling/disabling it), and takes a reasonably large work around when used...
The code in https://github.com/mitchellh/go-server-timing/blob/master/middleware.go#L97 currently calls: ```go headers.Set(HeaderKey, h.String()) ``` I am adding the timings to a http proxy and it would be good to not clober the downstream timing...
Hey there, so, I was wondering if there's a way to use `go-server-timing` with `gin-gonic/gin` using its middlewares?
Because the `headerWritten` bool is both read and modified outside of the protection of the mutex multiple calls to `writeHeader` are needlessly made. I suggest moving the `headerWritten` bool onto...
I noticed that having a metric with name that contains colons result in headers that are not valid (the parser confuses them to be the headers colons, I guess. I...
