go-mruby icon indicating copy to clipboard operation
go-mruby copied to clipboard

Support mruby 2.1.0

Open take-cheeze opened this issue 6 years ago • 4 comments

  • These tests are disabled temporary:
    • Use after free GC test
    • Nested exception raise test
  • Dropped support of 1.10 since staticcheck(ex-megacheck) doesn't support it
  • Using mruby-error gem(mrb_protect function) instead for exception handling.

take-cheeze avatar Dec 17 '19 05:12 take-cheeze

Hey! Awesome!

If you don't mind at least making sure it tests on 1.13 I would greatly appreciate it. It's in the .travis.yml file at the root of the repo.

I can work on 1.12 and getting go modules working after this patch is ready.

Thanks for contributing!

erikh avatar Dec 17 '19 06:12 erikh

oh, to clarify, I think dropping 1.10, and 1.11 support is probably worth it if it causes you to write unnecessary workarounds or other complexity.

@mitchellh I think I'm making a safe judgment call, but please shout out if you disagree.

erikh avatar Dec 17 '19 06:12 erikh

@erikh CI should be working now

take-cheeze avatar Dec 17 '19 07:12 take-cheeze

oh, to clarify, I think dropping 1.10, and 1.11 support is probably worth it if it causes you to write unnecessary workarounds or other complexity.

@mitchellh I think I'm making a safe judgment call, but please shout out if you disagree.

Totally safe. I think generally N, and N-1 are the versions you want to support which gives you 1 year of backwards support (Go is on 6mo cycles). Go 1.13 in particular was a rough version for a lot of projects to upgrade to due to major changes in Go modules behavior (we struggled at HashiCorp).

This is awesome though. Thanks @take-cheeze and @erikh!

mitchellh avatar Dec 17 '19 16:12 mitchellh