Mitchell Hashimoto
Mitchell Hashimoto
This should probably be a discussion but I'll allow it. We should cut a 1.2.4 release at some point that pins our theme dep to our own host, and ensure...
I'm fine with this. I think per surface is completely reasonable for this action. I think copy could improve but its good to me.
Apologies, I just got our tests passing again. Let me take a look at this now :)
Alright, this looks good, at least to start. I think the caveat that `once` may not complete everything is reasonable.
Actually I just quickly addressed them myself. CI running now, auto merge on!
We have a precedent for supporting multiple units within a single config, so my preference would be something like the following: * `quick-terminal-size` single configuration * A value ending in...
> Am I missing something, or is this a macOS-only feature for now? It is macOS only.
> My only feedback would be that mixing units feels a bit unintuitive but I’m not opposed to it at all, especially since we already have existing precedents for handling...
I should add: I imagine people will want different aligned quick terminals too. My proposal with `quick-terminal-size` is to always center align it vertically or horizontally depending on the position....
Marking this as accepted, if someone wants to PR it as proposed I will accept it. I'm still open to further feedback though.