Mitchell Hashimoto
Mitchell Hashimoto
> It's probably safest to assume that xdg-open can block and reap the child process asynchronously. Agreed. To keep things simple I'd just move the `wait` call to a thread,...
Thanks, this is looking good to me. I made some touchups, mostly style. I think functionally the most important is we must use `log.warn` and not `log.err`. `log.err` is for...
I know this isn't exactly shell integration, but its spiritually the correct tag for this lol.
My recommendation would be to change `window-inherit-working-directory` to an enum, with possible values: `false (never), true (always), tab (only new tabs), window (only on new windows)` or something like that....
> It seems like the Surface type doesn't know whether it's being presented as a tab or a window, and that's handled by the various "rt" implementations without a common...
To add to the "surface kind aware" note, we should also pipe through metadata about the kind of terminal we're looking at, because there is a significant amount of requests...
Okay had some extra time this morning so I read the other feedback. @pluiedev @jcollie I agree that we should have a `ghostty +ssh` option as well, but I see...
I agree with all of @jparise's feedback.
Yes to all of the above @jasonrayne, thanks for being receptive to feedback. > Terminfo/caching complexity This sounds good too. I need to study more what you're doing I didn't...
Thanks @jasonrayne. I'll reiterate my appreciation for you. The work here has been good, every iteration has been an improvement, and your reception to feedback and discussion has been excellent....