fiat-crypto icon indicating copy to clipboard operation
fiat-crypto copied to clipboard

Reverse dependency?

Open spitters opened this issue 3 years ago • 1 comments

As you know, we have a project depending on fiat-crypto/bedrock https://github.com/AU-COBRA/AUCurves

What would be the best way to set up CI? Would it be possible to run this as part of the fiat/bedrock CI? If so, what would be needed on our side?

spitters avatar May 18 '22 11:05 spitters

I think the best way to do this would be to support something like make EXTERNAL_DEPENDENCIES=1 to tell https://github.com/AU-COBRA/AUCurves to use an installed version of fiat-crypto rather than the submodule version. Then we can have our CI run make install and then build your dev. Perhaps an even better option would be to add an opam dev package for https://github.com/AU-COBRA/AUCurves that depends on the fiat-crypto opam package, and we can just opam install it on master branch (where we already check our opam package).

Btw, we implement EXTERNAL_DEPENDENCIES=1 with https://github.com/mit-plv/fiat-crypto/blob/cff358a16ed99176393792e0ecfbcb691a7cec15/Makefile#L414-L549

JasonGross avatar May 18 '22 13:05 JasonGross