rustreexo icon indicating copy to clipboard operation
rustreexo copied to clipboard
verified publisher icon mit-dci

Serde: use hex encoding for BitcoinNodeHash when (de)serializer is human-readable

Open Ash-L2L opened this issue 5 months ago • 4 comments

This could be smaller with hex-conservative::serde, but unfortunately the bitcoin-hashes/serde feature does not enable hex-conservative/serde. Adding hex-conservative as a direct dependency in order to enable the feature would require manually matching the version of hex-conservative to the version used in bitcoin-hashes.

Ash-L2L avatar Aug 07 '25 06:08 Ash-L2L

So. With this, rather than a vector of integers like [242, 80, 99...] we would get a hexadecimal (f25063...). That's nice! I think it would be nice to have some tests, tho

Davidson-Souza avatar Aug 08 '25 20:08 Davidson-Souza

Added tests!

A-Manning avatar Aug 12 '25 12:08 A-Manning

Not sure about the MSRV bump, we follow rust-bitcoin's for ecosystem compatibility.

Davidson-Souza avatar Aug 13 '25 16:08 Davidson-Souza

Not sure about the MSRV bump, we follow rust-bitcoin's for ecosystem compatibility.

Updated to only bump rust version for the CI tests. The version bump is only required for dev-dependencies, the crate will still build on 1.63.0

Ash-L2L avatar Aug 13 '25 19:08 Ash-L2L