lit icon indicating copy to clipboard operation
lit copied to clipboard

Restructure the way stuff is handled in lnp2p

Open Varunram opened this issue 6 years ago • 5 comments

Contains name changes, call by value / reference changes, removes unnecessary handler functions and more.

Varunram avatar Sep 29 '18 13:09 Varunram

test fails due to jenkins being down, unrelated to the PR itself.

Varunram avatar Sep 29 '18 13:09 Varunram

Don't mean to frustrate you with all the comments, I just made lnp2p very opinionated because I wanted to make it easier to refactor around.

delbonis avatar Oct 01 '18 16:10 delbonis

Yeah sure, the reason why we have reviews is to debate upon such points. I think we didn't review / discuss upon the refactor PR much before merging, so it makes sense to review them here.

Varunram avatar Oct 03 '18 12:10 Varunram

There are several large binary files in this PR, can you remove them (and maybe rebuild the git commit log to never have them so they're not included in the history)

adiabat avatar Oct 17 '18 17:10 adiabat

should be good now

Varunram avatar Oct 17 '18 17:10 Varunram