lit icon indicating copy to clipboard operation
lit copied to clipboard

Replace By Fee transactions

Open Varunram opened this issue 7 years ago • 4 comments

A WIP PR to test Replace by Fee.

Varunram avatar Nov 18 '17 15:11 Varunram

I know it's WIP / starting out, but some thoughts:

probably don't need a bool for txs or for the wallet, and can just always have RBF on. The whole idea of "opt in RBF" is kindof silly / political thing, because you can't prevent RBF, even with soft forks or whatever; that's the whole point of the mining after all. So it's kindof fooling people to pretend that you can turn off RBF.

Another thing is that the lightning commitment txs all have non-final sequence numbers. Also the non-justice txs spending the commitment outputs also have non-final sequence because they use OP_CSV.

So probably can just leave out settings and set normal txs from the wallet to have non-final sequence. That part's easy; then some kind of bump-fee management would be most of the code.

adiabat avatar Nov 21 '17 03:11 adiabat

Just updated to signal RBF. Will update you on this today :)

Varunram avatar Nov 21 '17 13:11 Varunram

@adiabat Stuff kinda works (there are still issues with rejected tx's as expected), would love to have you test it out!

Varunram avatar Nov 23 '17 16:11 Varunram

This would be good to come back to at some point, and add tests with highly variable fee rates

adiabat avatar Jun 19 '18 14:06 adiabat