Josh Kellendonk

Results 46 comments of Josh Kellendonk

> Would like to hear the take of other maintainers, as well as your opinion on the above, before moving forward I like where this is headed. It makes practical...

> Would love to have your opinion on the current direction. Thanks for your work so far. I'll be in a better position to take a look this evening.

> @misterjoshua: sorry for the notification but I have noticed you gave a thumbs up to this issue, are you also experiencing this same behavior? @dreamorosi I had a similar...

@dreamorosi Just as an aside, here's another interesting edge case where specifying `subSegmentName` will be useful. ![image](https://user-images.githubusercontent.com/644092/191129775-d379cc81-289c-4799-a42c-eb3135b514d0.png) In this case, the tracer tries to derive the name of the segment...

I've had this error happen when I hadn't added Projen's `PROJEN_GITHUB_TOKEN` secret to the repo. I synthed the provided projenrc and got this `upgrade-main.yml` which seems to want `PROJEN_GITHUB_TOKEN`: ```yaml...

`upgrade-main` needs to create the PR with a different token than typical GitHub actions. Otherwise, GitHub's security prevents the PR's CI from running. So you couldn't use the standard `GITHUB_TOKEN`...

Here's a demonstration of how this looks on a local test project: https://user-images.githubusercontent.com/644092/183526428-f16e5488-fa14-41e5-9b3b-7174e1a2fc84.mp4

I'm unsure whether I should be updating a README for this one - should I rename this to a `fix` so the PR linter doesn't complain? Edit: I've changed it...

> Would this update Lambda code also before deploying stacks? @niebloomj Nope. Same as before, it puts the assets in a bucket or ECR repository during publishing, but no changes...

> @misterjoshua I'm a concerned this PR reverts recent gains made by #19378 Specifically it looks like asset publishing is now a synchronous operation for all stacks. @mrgrain It should...