avizo icon indicating copy to clipboard operation
avizo copied to clipboard

Scripts use /bin/sh but depends on non-posix extensions

Open hen6003 opened this issue 2 years ago • 2 comments

This causes lightctl to fail on voidlinux, as line 116 causes the script to crash. Replacing /bin/sh with /bin/bash fixes this

hen6003 avatar Sep 07 '22 21:09 hen6003

https://github.com/misterdanb/avizo/blob/67af5fd55279c25546d79cebdb4cb73440093082/lightctl#L116

added in #44. Moreover, it’s unnecessary, this can be easily written as light=${light%%.*}. And that is_float condition is also unnecessary.

jirutka avatar Sep 07 '22 21:09 jirutka

@jirutka Have you tested the suggested change? I'm not a bash/sh expert, so I rely on some suggestions. Do you want to make a pull request? (I can also just integrate the change if it's really that simple)

heyjuvi avatar Nov 05 '22 18:11 heyjuvi