CoPilot
CoPilot copied to clipboard
misterGF
Using SCSS/LESS instead of CSS
Added AdminLTE LESS files, and integrated them into the Webpack config to include LESS in the build process. Let me know if you have any thoughts for improvements, or if I've missed out on anything.
Included are the skin files as well, with the blue skin used by default - to change this, simply replace with respective colour named file in 'build/webpack.base.conf.js'
This is in response to the earlier issue: https://github.com/misterGF/CoPilot/issues/19 - as per @misterGF 's comment, here is the PR.
P.S. I see you've closed the issue earlier after euvl's commit - his commits did not tackle the full LESS support - but rather only partial modules being rewritten into SASS.
I think a value addition to this would be linting for the LESS with either Lesshint (personal fav) or Stylelint.
Hey @vpiskunov. I'm on it this week!
I added a bad commit in your PR while attempting to fix some dependency changes since you submitted. Could you remove it?
I also tested your fork and get this error. This is using node 6.9.
Thoughts?
Hey @misterGF ! Good to hear, I'll have a look at your bad commit tomorrow or day after, but in the mean time regarding errors in my fork - seems like the files could be missing or path is wrong.
Can you locate the .less files manually in that branch checked out? If so, let me know at which path they are placed.
Yes, I haven't heard about any updates. @vpiskunov. Have you had a chance to look at this?
@misterGF Hi, I asked you on your previous comment - haven't heard your feedback on:
seems like the files could be missing or path is wrong.
Can you locate the .less files manually in that branch checked out? If so, let me know at which path they are placed.
That's kind of crucial for me to understand where the errors could arise from - it worked in my environment. So let me know.
I thought @misterGF had merged this long time back?
Also seems theres been a lot of changes since my initial pull request, so unless it was merged, might be easier to re-implement than fix.
@vpiskunov. Could never get it to properly build. I’m still interested in getting this merged. If you could re-implement I can make it a priority to get this merged.