throttle-proxy icon indicating copy to clipboard operation
throttle-proxy copied to clipboard

Published 20 hours ago • verified publisher icon mistakster

Provide speed presets

Open CashWilliams opened this issue 9 years ago • 5 comments

Would be nice feature to add some common speed presets, such as ones provided by Chrome

speeds

CashWilliams avatar Feb 23 '16 15:02 CashWilliams

Some presets for the speed would be awesome!

SassNinja avatar Oct 05 '18 11:10 SassNinja

@mistakster what do you think about this?

I might dig into the code and try to submit a PR. But I don't wanna waste my time if it never gets merged due to inactivity.

SassNinja avatar Jul 11 '19 08:07 SassNinja

Hi, @SassNinja. The project is active.

Sorry, I have no idea how the presets can significantly improve the DX. I'm happy to discuss and approve your PR if you are going to make it.

I think, the presets should modify existing options. So, all amends can be done in https://github.com/mistakster/throttle-proxy/blob/master/lib/args.js

mistakster avatar Jul 11 '19 08:07 mistakster

Thanks for the quick reply! I'm glad to hear the project is still active :-) I'll create a PR once I've got a bit time.

Sorry, I have no idea how the presets can significantly improve the DX.

It's about avoiding to enter the exact speed values over and over again. The chrome dev tools are a good example: you can just pick the Fast 3G preset and don't need to care about anything else.

SassNinja avatar Jul 11 '19 09:07 SassNinja

Yeah, I see. But when you in CLI, you have to memorize all the names. And it's not clear how to deal with white space in the name of the preset.

mistakster avatar Jul 11 '19 09:07 mistakster