perfect6502 icon indicating copy to clipboard operation
perfect6502 copied to clipboard
verified publisher icon mist64

Fix measure.c memory leak and warnings/errors with newer gcc/glibc and vc++

Open rheit opened this issue 5 years ago • 2 comments

This patch fixes warnings from gcc and glibc that prevent compilation with -Werror, updates apple1basic.c to the new API, fixes the #ifdef _WIN32 block in that file, and fixes a memory leak in measure.c.

I fixed the Makefile issue by creating a single Makefile that can build cbmbasic, apple1basic, and measure all at once or individually. However, since this changes the Makefile system from three files to one, I left it out of this pull request. If desired, I could add that. The other alternative is to comment out the OBJS+=measure.o line again.

rheit avatar Dec 03 '20 00:12 rheit

Nice, builds clean on gcc9 and gcc10. This would fix #9

drfiemost avatar Dec 13 '20 12:12 drfiemost

This pull request also fixes an unreported massive memory leak in measure.c, resetChip_test(). This fact should be made more prominent. Or should the error be reported to catch the developer's attention?

Edit: Oh, I see rheit has mentioned it in the first sentence. Still, it is an important fix, but it’s all too easy to skim over it.

szabadulas avatar Dec 16 '20 10:12 szabadulas