misskey icon indicating copy to clipboard operation
misskey copied to clipboard

"Remove follower" does not work due to referencing wrong Follow ID

Open trwnh opened this issue 2 years ago • 1 comments

💡 Summary

"Remove follower" does not work due to wrong Follow ID

🥰 Expected Behavior

A Reject Follow is sent out referencing the remote Follow ID, or null ID for transient Follow activity

🤬 Actual Behavior

A Reject Follow is sent out referencing the local Follow ID

📝 Steps to Reproduce

  1. Try to Remove follower

📌 Environment

Misskey version: 12.119.0

image

Simplified representation of the activity:

id: misskey.bubbletea.dev/1153...
actor: misskey.bubbletea.dev/users/8r0...
type: Reject
object:
    id: misskey.bubbletea.dev/follows/97hb...
    actor: akkoma.trwnh.com/users/a
    type: Follow
    object: misskey.bubbletea.dev/users/8r0...

Akkoma fails to recognize the Follow by its remote ID. This is a bug in Akkoma, but Misskey should probably send remote/original Follow ID if it is available. Otherwise id should not be included.

Acceptable solution:

id: misskey.bubbletea.dev/1153...
actor: misskey.bubbletea.dev/users/8r0...
type: Reject
object:
    actor: akkoma.trwnh.com/users/a
    type: Follow
    object: misskey.bubbletea.dev/users/8r0...

Also acceptable solution:

id: misskey.bubbletea.dev/1153...
actor: misskey.bubbletea.dev/users/8r0...
type: Reject
object:
    id: akkoma.trwnh.com/...
    actor: akkoma.trwnh.com/users/a
    type: Follow
    object: misskey.bubbletea.dev/users/8r0...

trwnh avatar Dec 01 '22 18:12 trwnh

Just a note that this bug may also result in being unable to refollow that same user later. With 13.4.0, I'm currently unable to refollow users on pleroma, which I think is due to this bug

shibaobun avatar Feb 05 '23 20:02 shibaobun

not fixed by #10600. "remove follower" still does not work due to id of inner Follow when sending out Reject Follow

trwnh avatar Apr 20 '23 14:04 trwnh