misskey icon indicating copy to clipboard operation
misskey copied to clipboard

Thread sorting setting into user profile (LIFO/FIFO)

Open tassoman opened this issue 3 years ago • 7 comments

As User I would like to configure threads sorting by switching a profile setting between LIFO or FIFO

Checking the two links, you can find the same thread. Readings inside Mastodon appears from older to newer. When you read notes inside Misskey they appear from newer to older.

Some users feels such a weird behavior and asked for a profile configuration setting who let everyone choose their favorite order.

Maybe happen?

tassoman avatar Nov 08 '22 22:11 tassoman

Related (maybe depend) to #8454

acid-chicken avatar Nov 09 '22 12:11 acid-chicken

The API endpoint notes/children doesn't have any ordering by parameter. I loaded the thread page and I seem to understand it just fetches note/children recursively asking 5 items. So that, IMO, the "order by" event should be coded in the client. Maybe you said could be related, because of this? My hypothesis: this should be easy to code, only a flag setting is needed, then by the flag, the routine should iterate from older to newer or viceversa. :thinking: (I didn't explored the code)

tassoman avatar Nov 09 '22 19:11 tassoman

This endpoint can be sorted in ascending order by passing sinceId without passing untilId.

https://github.com/misskey-dev/misskey/blob/24d18a7b19d6ee803578fc0e044fd377fcf587ef/packages/backend/src/core/QueryService.ts#L34-L42

And, #8454 points out that reply notes are not paginated. To solve that problem, the trailing ID must be passed to the endpoint in order to display subsequent posts anyway. Then, this issue can be solved at the same time by toggling whether the ID is passed to sinceId or untilId.

acid-chicken avatar Nov 10 '22 18:11 acid-chicken

Cooler than expected! I hope can be integrated. If you're reading this comment in the future and interested into having ability to order threads from older to newer and viceversa, please up-vote with a :+1: :smiley_cat:

tassoman avatar Nov 12 '22 01:11 tassoman

@syuilo MkNoteDetailedrepliesMkNoteSub で表示させるところに MkPagination 使わなかった理由ってある?

acid-chicken avatar Nov 13 '22 04:11 acid-chicken

@syuilo MkNoteDetailedrepliesMkNoteSub で表示させるところに MkPagination 使わなかった理由ってある?

特になかったと思う

syuilo avatar Nov 13 '22 05:11 syuilo

@syuilo MkNoteDetailedrepliesMkNoteSub で表示させるところに MkPagination 使わなかった理由ってある?

特になかったと思う

🙏 じゃあそこで MkPagination 使う(+設定項目を増やす)ことで #8454 と両方解決しそう

acid-chicken avatar Nov 13 '22 10:11 acid-chicken