misskey-dev
[minify-backend用] フィジビリティ検証
What
https://github.com/misskey-dev/misskey/issues/16852 向け。developではなくminify-backendブランチに向けています。 backendのminifyが可能かどうかを検証 →node_modulesは含んでいないが、バックエンド単体のminifyそのものは出来た
Why
Additional info (optional)
Checklist
- [ ] Read the contribution guide
- [ ] Test working in a local environment
- [ ] (If needed) Add story of storybook
- [ ] (If needed) Update CHANGELOG.md
- [ ] (If possible) Add tests
いちおう現時点までの最新まで追従しますが、 https://github.com/misskey-dev/misskey/pull/16889 も入れないと完全にはならなさそうです
バンドルなしでnode_modulesのminifyは https://github.com/misskey-dev/misskey/pull/16904 で一応可能ということが分かったのでひとまずバックエンド単体のminifyで十分かもしれない
- 🎉 と思ったけど、結局相対パス絡みでbuild-assets.mjsまわりの改修が入るのでやっぱり https://github.com/misskey-dev/misskey/pull/16889 が欲しいかもしれない
- ちょっと所用で1時間ばかり作業不可になるので追従が送れるかもしれない
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:warning: Please upload report for BASE (minify-backend@ab5c388). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## minify-backend #16878 +/- ##
=================================================
Coverage ? 13.97%
=================================================
Files ? 237
Lines ? 11271
Branches ? 3726
=================================================
Hits ? 1575
Misses ? 7577
Partials ? 2119
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}