misskey icon indicating copy to clipboard operation
misskey copied to clipboard

refactor: pnpm catalog

Open samunohito opened this issue 7 months ago • 6 comments

What

Why

fix #16007

Additional info (optional)

動作確認

  • [ ] clone -> export NODE_ENV=production -> pnpm i -> pnpm build -> pnpm start
  • [ ] 既存テスト全pass
  • [ ] Dockerfile

Checklist

  • [ ] Read the contribution guide
  • [ ] Test working in a local environment
  • [ ] (If needed) Add story of storybook
  • [ ] (If needed) Update CHANGELOG.md
  • [ ] (If possible) Add tests

samunohito avatar May 17 '25 01:05 samunohito

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.99%. Comparing base (0133dbf) to head (58cb05d). :warning: Report is 766 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #16059      +/-   ##
===========================================
+ Coverage    46.10%   47.99%   +1.89%     
===========================================
  Files         1704     1710       +6     
  Lines       173299   179900    +6601     
  Branches      5295     5302       +7     
===========================================
+ Hits         79899    86346    +6447     
- Misses       92920    93091     +171     
+ Partials       480      463      -17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 17 '25 01:05 codecov[bot]

このPRによるapi.jsonの差分 差分はありません。 Get diff files from Workflow Page

github-actions[bot] avatar May 17 '25 01:05 github-actions[bot]

現状は複数のpackage.jsonで使用されているパッケージのみcatalog化しています。

  • 全部catalogに乗せてしまっても良いのでは?
  • backendに乗るもの、frontendに乗るもの、misskey-jsという粒度で区切った方が良いのでは

みたいな内なる声もあり、ご意見募集中

samunohito avatar May 17 '25 01:05 samunohito

パッケージをまたいで共通のdependencyが増えたら自動でcatalogに移行するみたいな設定ができそうなら共通のものだけでよさそう

kakkokari-gtyih avatar May 19 '25 05:05 kakkokari-gtyih

パッケージをまたいで共通のdependencyが増えたら自動でcatalogに移行するみたいな設定

現状無いかもです(ざっと見た限りなさそう?)

samunohito avatar May 19 '25 11:05 samunohito

パッケージをまたいで共通のdependencyが増えたら自動でcatalogに移行するみたいな設定ができそうなら共通のものだけでよさそう

無いなら、重複があったらCIではねるようにしてもよさそう

kakkokari-gtyih avatar May 22 '25 03:05 kakkokari-gtyih

コンフリえぐいのでclose

samunohito avatar Oct 31 '25 23:10 samunohito