Fix: Continue importing from file if single emoji import fails
What
Add a try/catch block to the DriveService.addFile call to allow other emojis to be processed in the case of a missing one.
Why
There are potentially still good emojis in a file after one bad one, so interrupting the import process is bad behavior.
Additional info (optional)
Checklist
- [x] Read the contribution guide
- [x] Test working in a local environment
- [x] (If needed) Update CHANGELOG.md
Fixes #14460
Codecov Report
Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
Project coverage is 39.56%. Comparing base (
a37df2c) to head (d6f1bc3). Report is 2 commits behind head on develop.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...e/processors/ImportCustomEmojisProcessorService.ts | 0.00% | 24 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #14461 +/- ##
===========================================
- Coverage 39.63% 39.56% -0.08%
===========================================
Files 1542 1542
Lines 192690 192697 +7
Branches 3562 3533 -29
===========================================
- Hits 76376 76234 -142
- Misses 115717 115866 +149
Partials 597 597
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Does this close #14460 ? Please link it in the description from here if it does.
i have done so
conflict resolved
🙏🏻