misskey icon indicating copy to clipboard operation
misskey copied to clipboard

enhance: 人気のPlayを10件以上表示できるように

Open samunohito opened this issue 1 year ago • 2 comments

※https://github.com/misskey-dev/misskey/pull/14439 に含まれるMkPaginationのfixが必要です

What

Playの「人気」タブに10件以上表示できるようになります。

Why

fix: https://github.com/misskey-dev/misskey/issues/14399

Additional info (optional)

テストを作成して確認

Checklist

  • [x] Read the contribution guide
  • [x] Test working in a local environment
  • [ ] (If needed) Add story of storybook
  • [x] (If needed) Update CHANGELOG.md
  • [x] (If possible) Add tests

samunohito avatar Aug 19 '24 22:08 samunohito

Codecov Report

Attention: Patch coverage is 60.63830% with 37 lines in your changes missing coverage. Please review.

Project coverage is 41.29%. Comparing base (8869846) to head (a528aa6). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...es/backend/src/core/entities/FlashEntityService.ts 3.33% 29 Missing :warning:
...backend/src/server/api/endpoints/flash/featured.ts 45.45% 6 Missing :warning:
packages/frontend/src/pages/flash/flash-index.vue 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14443      +/-   ##
===========================================
+ Coverage    39.57%   41.29%   +1.72%     
===========================================
  Files         1548     1553       +5     
  Lines       194523   200329    +5806     
  Branches      3600     3640      +40     
===========================================
+ Hits         76982    82735    +5753     
- Misses      116973   116993      +20     
- Partials       568      601      +33     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 19 '24 22:08 codecov[bot]

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -63665,6 +63665,29 @@
         "tags": [
           "flash"
         ],
+        "requestBody": {
+          "required": true,
+          "content": {
+            "application/json": {
+              "schema": {
+                "type": "object",
+                "properties": {
+                  "offset": {
+                    "type": "integer",
+                    "minimum": 0,
+                    "default": 0
+                  },
+                  "limit": {
+                    "type": "integer",
+                    "minimum": 1,
+                    "maximum": 100,
+                    "default": 10
+                  }
+                }
+              }
+            }
+          }
+        },
         "responses": {
           "200": {
             "description": "OK (with results)",

Get diff files from Workflow Page

github-actions[bot] avatar Aug 19 '24 22:08 github-actions[bot]

MkPaginationがマージされての出open

samunohito avatar Oct 05 '24 04:10 samunohito

👍🏿

syuilo avatar Oct 05 '24 05:10 syuilo