misskey
misskey copied to clipboard
fix(backend): update ApPersonService to handle user without endpoint
What
Fix #13735
Why
endpoint または sharedInbox がnullの場合、更新をスキップします
Additional info (optional)
Checklist
- [X] Read the contribution guide
- [X] Test working in a local environment
- [ ] (If needed) Add story of storybook
- [ ] (If needed) Update CHANGELOG.md
- [ ] (If possible) Add tests
Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
Project coverage is 40.16%. Comparing base (
efb0429) to head (2f55c80). Report is 14 commits behind head on develop.
| Files | Patch % | Lines |
|---|---|---|
| ...end/src/core/activitypub/models/ApPersonService.ts | 0.00% | 6 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #14080 +/- ##
===========================================
- Coverage 42.07% 40.16% -1.91%
===========================================
Files 1527 1523 -4
Lines 195068 189025 -6043
Branches 2688 2668 -20
===========================================
- Hits 82079 75931 -6148
- Misses 112448 112553 +105
Partials 541 541
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
「sharedInboxがなくなった」という内容のアップデートがあった場合にnullに更新できなくなりそう
「sharedInboxがなくなった」という内容のアップデートがあった場合にnullに更新できなくなりそう
はい、ただし、どのような状況でsharedInboxがもともと存在していた状況がsharedInboxが存在しない状況、つまりnullの状況になるのかはわかりません。