misskey icon indicating copy to clipboard operation
misskey copied to clipboard

enhance(frontend/dev): storeのバックアップキーの指定方法を簡略化

Open kakkokari-gtyih opened this issue 1 year ago • 5 comments

What

storeの定義の段階で設定のバックアップに含むかどうかを指定できるようにした

{
	additionalUnicodeEmojiIndexes: {
		where: 'device',
+		ignoreBackup: true,
		default: {} as Record<string, Record<string, string[]>>,
	},
}

Why

Fix #13419

Additional info (optional)

Checklist

  • [x] Read the contribution guide
  • [ ] Test working in a local environment
  • [ ] (If needed) Add story of storybook
  • [ ] (If needed) Update CHANGELOG.md
  • [ ] (If possible) Add tests

kakkokari-gtyih avatar Mar 12 '24 07:03 kakkokari-gtyih

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.69%. Comparing base (5c1d86b) to head (910377f). Report is 1180 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13560       +/-   ##
============================================
+ Coverage    64.83%   77.69%   +12.85%     
============================================
  Files          986      185      -801     
  Lines       111009    25053    -85956     
  Branches      4424      484     -3940     
============================================
- Hits         71974    19464    -52510     
+ Misses       39003     5582    -33421     
+ Partials        32        7       -25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 12 '24 07:03 codecov[bot]

ストア側がバックアップ機能ドメインを知るのは微妙な感じがするわね

syuilo avatar Mar 16 '24 01:03 syuilo

そうなんだ

kakkokari-gtyih avatar Mar 16 '24 01:03 kakkokari-gtyih

ストア側がバックアップ機能ドメインを知るのは微妙な感じがする

そう?(ストアの定義にバックアップの情報を書くだけでストアがバックアップに関与するわけではないし…

tamaina avatar Mar 16 '24 05:03 tamaina

ストア側がバックアップ機能ドメインを知るのは微妙な感じがするわね

そもそも where もそう(defaultStore に全部まとめなければいいのでは)

acid-chicken avatar Mar 16 '24 17:03 acid-chicken