misskey
misskey copied to clipboard
fix(federation): AnnounceのobjectがNoteでなかったらキューにためない
Fix https://github.com/misskey-dev/misskey/issues/13552
What
ApNoteService.validateNoteのエラーにIdentifiableErrorを設定し、InboxProcessorServiceで受け取ったらキューにためないようにする- Inboxプロセスで返されてくるreason stringをちゃんとハンドリングする
Why
Additional info (optional)
Checklist
- [ ] Read the contribution guide
- [ ] Test working in a local environment
- [ ] (If needed) Add story of storybook
- [ ] (If needed) Update CHANGELOG.md
- [ ] (If possible) Add tests
Codecov Report
Attention: Patch coverage is 2.63158% with 74 lines in your changes are missing coverage. Please review.
Project coverage is 65.07%. Comparing base (
f8261a1) to head (9586c3d). Report is 593 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #13553 +/- ##
============================================
- Coverage 79.95% 65.07% -14.89%
============================================
Files 956 989 +33
Lines 108864 112500 +3636
Branches 8413 5805 -2608
============================================
- Hits 87045 73208 -13837
- Misses 21819 39261 +17442
- Partials 0 31 +31
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@syuilo これはマージしたい
ん?そうかこれは #13610 に含まれてた